Fix "RangeError: Maximum call stack size exceeded" exception when labels are big (>125000) - #5935 #5936
Merged
simonbrunel merged 3 commits intochartjs:masterfrom Dec 31, 2018
Merged
Conversation
ckyycc
changed the title
benmccann
reviewed
Dec 26, 2018
benmccann
previously approved these changes
Dec 26, 2018
kurkle
reviewed
Dec 28, 2018
kurkle
approved these changes
Dec 28, 2018
benmccann
approved these changes
Dec 28, 2018
etimberg
approved these changes
Dec 29, 2018
simonbrunel
approved these changes
Dec 31, 2018
Member
|
Thanks @ckyycc |
This was referenced Mar 4, 2020
This was referenced Mar 9, 2020
This was referenced Apr 14, 2020
exwm
pushed a commit
to exwm/Chart.js
that referenced
this pull request
Apr 30, 2021
Fix "RangeError: Maximum call stack size exceeded" exception when calling `Array.push.apply` with too many items (>125000).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Below is copied from MDN Function.prototype.apply:
But beware: in using apply this way, you run the risk of exceeding the JavaScript engine's argument length limit.
Fixes #5935