Cleanup scales export for better import strategy#5953
Merged
simonbrunel merged 7 commits intochartjs:masterfrom Jan 5, 2019
Merged
Cleanup scales export for better import strategy#5953simonbrunel merged 7 commits intochartjs:masterfrom
simonbrunel merged 7 commits intochartjs:masterfrom
Conversation
Scales now export a function responsible to register the scale class and associated defaults while the definition has been moved outside the exported function.
benmccann
reviewed
Jan 4, 2019
simonbrunel
force-pushed
the
chore/importable-scales
branch
from
1d00765 to
93850b6
Compare
kurkle
reviewed
Jan 4, 2019
Member
kurkle
left a comment
kurkle
left a comment
There was a problem hiding this comment.
Cant fully review on mobile, whitespace ignoring setting is not obeyed on larger diffs. Will do full review later.
benmccann
reviewed
Jan 4, 2019
benmccann
reviewed
Jan 4, 2019
benmccann
previously approved these changes
Jan 4, 2019
etimberg
reviewed
Jan 5, 2019
src/chart.js
Outdated
| Chart.elements = require('./elements/index'); | ||
| Chart.Interaction = require('./core/core.interaction'); | ||
| Chart.layouts = require('./core/core.layouts'); | ||
| Chart.LinearScaleBase = require('./scales/scale.linearbase'); |
Member
There was a problem hiding this comment.
Can we add a comment to remove this at v3 since it should be internal only?
etimberg
reviewed
Jan 5, 2019
Member
etimberg
left a comment
etimberg
left a comment
There was a problem hiding this comment.
Just one minor comment. Looks good
kurkle
approved these changes
Jan 5, 2019
Member
kurkle
left a comment
kurkle
left a comment
There was a problem hiding this comment.
Had to look hard, but found eventually a line to comment on 😈
etimberg
approved these changes
Jan 5, 2019
9 tasks
This was referenced Mar 4, 2020
This was referenced Mar 9, 2020
This was referenced Apr 14, 2020
exwm
pushed a commit
to exwm/Chart.js
that referenced
this pull request
Apr 30, 2021
Scales now export their class and associated defaults (`_defaults`), the registration being done globally in `src/chart.js`.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Scales now export a function responsible to register the scale class and associated defaults while the definition has been moved outside the exported function.
Relates #4478
Closes #5941