supply correct start parameter to insertElements#6008
Merged
simonbrunel merged 2 commits intochartjs:masterfrom Jan 25, 2019
Merged
supply correct start parameter to insertElements#6008simonbrunel merged 2 commits intochartjs:masterfrom
simonbrunel merged 2 commits intochartjs:masterfrom
Conversation
etimberg
reviewed
Jan 23, 2019
etimberg
approved these changes
Jan 23, 2019
benmccann
approved these changes
Jan 25, 2019
simonbrunel
approved these changes
Jan 25, 2019
This was referenced Mar 4, 2020
This was referenced Mar 9, 2020
This was referenced Apr 14, 2020
exwm
pushed a commit
to exwm/Chart.js
that referenced
this pull request
Apr 30, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
in onDataPush, data is already in the data array.
So say the data was [1,2,3] before push and [4,5,6] was pushed.
Because data is already in place here, data.length would be 6 so start parameter would have been 5 to insertElement.
spliceis executed on meta.data there, with given the index relative to start.In
MDN its said about start: "If greater than the length of the array, actual starting index will be set to the length of the array."
So the wrong
startis fixed by splice.However, when used for something else (I did), then things would go wrong. So this might as well be fixed for possible future changes.