Provide a rectangle getArea implementation for horizontal bars#6027
Provide a rectangle getArea implementation for horizontal bars#6027simonbrunel merged 2 commits intochartjs:masterfrom
Conversation
|
Should we mark the method as deprecated as well? |
kurkle
left a comment
There was a problem hiding this comment.
I'm not sure this should be deprecated, its probably needed at some point anyway.
As a side note (v3 in mind): width and height should be "right", so this is kind of wrong place to check orientation.
|
That's the kind of methods we would have preferred private. |
|
Looks like you'll need to rebase this against master after #6039 is merged to get Travis to pass |
75dd70f to
093d950
Compare
|
Disclaimer: this has little or nothing to do with this PR For V3 we should think of removing orientation from I would also brainstorm more around the properties, we should be able to extract at least configurable and those that should be transitioned. We should also try not to have to check for |
Resolves #4480
It should be noted that since #5857
getArea()is not used anywhere in the code.I considered removing the method from the different elements but that would be a breaking change. I don't think anyone is using it, but we can't guarantee it.