Use lowercase for primitives in jsdocs

[benmccann]

No description provided.

[etimberg]

Is this recommended by JSDocs?

[benmccann]

I don't think jsdoc necessarily cares. I was mostly doing this for consistency with #6020

Typescript cares, so this may make it easier to support in the future: https://www.typescriptlang.org/docs/handbook/declaration-files/do-s-and-don-ts.html

[kurkle]

Didn't go through all, but I think Object should still be capitalized. Also noticed there are issues with the jsdocs, so maybe it would better to remove all but

/**
 * @private
 * /

from private functions.

I don't have any strong feelings about these, so this review should be regarded as a comment rather than a request for changes.

[benmccann]

Our docs use lowercase object as does typescript, so I think lowercase would be more consistent

[nagix]

Chart.js/src/core/core.scale.js

Line 719 in 6e9e52a

// @param {rectangle} chartArea : the area of the chart to draw full grid lines on

Is rectangle also an interface?

[benmccann]

@nagix I fixed the rectangle reference

[nagix]

There are a few other lines that have JSDoc-style comments but start with //. Shouldn't they also be fixed?

[benmccann]

Ok. I've changed all the rest as well. Thanks for catching that

[nagix]

I realized that those blocks all don't have types. Types are not required in JSDoc, but it might be better to include for consistency (and : should be replaced with -).

[benmccann]

Ok, I've gone through and replaced the : as well. I will leave adding more types for later as it's getting to be a bit outside the scope of this PR. I would want to be careful to document the correct type and there's quite a few places where we don't have any @return or @param where we could add more types as well

[nagix]

Thanks for all the changes, looks good to me.

[simonbrunel]

Great work @benmccann!

[nagix]

Thanks for all the cleanups!

[benmccann]

Thanks for the reviews!