Merged
Conversation
benmccann
reviewed
Feb 3, 2019
simonbrunel
requested changes
Feb 4, 2019
Member
simonbrunel
left a comment
simonbrunel
left a comment
There was a problem hiding this comment.
Awesome work @nagix (and thanks for all the unit tests)
simonbrunel
previously approved these changes
Feb 4, 2019
benmccann
previously approved these changes
Feb 4, 2019
kurkle
reviewed
Feb 4, 2019
kurkle
previously approved these changes
Feb 4, 2019
benmccann
previously approved these changes
Feb 4, 2019
Member
|
@nagix do you want to add a scriptable example for |
Contributor
Author
|
As it seems @janelledement agreed to add more examples, I would leave it to her😉. |
simonbrunel
approved these changes
Feb 9, 2019
Member
simonbrunel
left a comment
simonbrunel
left a comment
There was a problem hiding this comment.
Looks really good. Maybe some tests may not fail enough in case of change (e.g. the point rotation with a line symbol) but it should be fine.
kurkle
approved these changes
Feb 9, 2019
etimberg
approved these changes
Feb 9, 2019
janelledement
pushed a commit
to janelledement/Chart.js
that referenced
this pull request
Feb 10, 2019
jonrimmer
pushed a commit
to jonrimmer/Chart.js
that referenced
this pull request
Feb 14, 2019
This was referenced Mar 4, 2020
This was referenced Mar 9, 2020
This was referenced Apr 14, 2020
exwm
pushed a commit
to exwm/Chart.js
that referenced
this pull request
Apr 30, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Background
This PR introduces scriptable configuration options for points on radar charts. The user can script the styling and interaction options.
Testing
The existing unit tests covering the setHoverStyle dataset controller method were removed as they did not have proper setup for use with scriptable options.
Fixture based tests were written to test:
pointBackgroundColorpointBorderColorpointBorderWidthpointRadiuspointRotationpointStyleDocumentation
I updated the radar chart documentation to match the style of the line charts.