Handle a frozen dataset.data array.#6060
Merged
simonbrunel merged 6 commits intochartjs:masterfrom Feb 11, 2019
Merged
Conversation
benmccann
reviewed
Feb 10, 2019
kurkle
requested changes
Feb 10, 2019
Member
kurkle
left a comment
kurkle
left a comment
There was a problem hiding this comment.
I agree with @benmccann, the documentaton change is not needed.
simonbrunel
reviewed
Feb 10, 2019
kurkle
previously approved these changes
Feb 10, 2019
benmccann
previously approved these changes
Feb 10, 2019
Contributor
|
I just wondered if we should use |
Member
Author
|
@nagix I updated to use |
benmccann
previously approved these changes
Feb 10, 2019
simonbrunel
reviewed
Feb 10, 2019
nagix
previously approved these changes
Feb 11, 2019
kurkle
previously approved these changes
Feb 11, 2019
simonbrunel
approved these changes
Feb 11, 2019
Member
simonbrunel
left a comment
simonbrunel
left a comment
There was a problem hiding this comment.
Looks great, thanks Evert!
kurkle
approved these changes
Feb 11, 2019
benmccann
approved these changes
Feb 11, 2019
jonrimmer
pushed a commit
to jonrimmer/Chart.js
that referenced
this pull request
Feb 14, 2019
This was referenced Mar 4, 2020
This was referenced Mar 9, 2020
This was referenced Apr 14, 2020
exwm
pushed a commit
to exwm/Chart.js
that referenced
this pull request
Apr 30, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #4157. I added a note to the documentation regarding the fact that frozen data will not support live updates.
Fiddle with v2.7.3
Fiddle with these changes