Fix randomly failing tooltip test#6061
Merged
simonbrunel merged 1 commit intochartjs:masterfrom Feb 10, 2019
Merged
Conversation
simonbrunel
approved these changes
Feb 10, 2019
etimberg
approved these changes
Feb 10, 2019
benmccann
reviewed
Feb 10, 2019
| var point = meta.data[pointIndex]; | ||
| var node = chart.canvas; | ||
| var rect = node.getBoundingClientRect(); | ||
| var evt = new MouseEvent('mousemove', { |
Contributor
There was a problem hiding this comment.
There are a lot of other places in this file where we're creating a new MouseEvent instead of calling triggerMouseEvent. Do they need to be updated as well?
janelledement
pushed a commit
to janelledement/Chart.js
that referenced
this pull request
Feb 10, 2019
Use utility to trigger the event in the center of element rather than x/y -based coordinates (its the edge for rectangles)
jonrimmer
pushed a commit
to jonrimmer/Chart.js
that referenced
this pull request
Feb 14, 2019
Use utility to trigger the event in the center of element rather than x/y -based coordinates (its the edge for rectangles)
This was referenced Mar 4, 2020
This was referenced Mar 9, 2020
This was referenced Apr 14, 2020
exwm
pushed a commit
to exwm/Chart.js
that referenced
this pull request
Apr 30, 2021
Use utility to trigger the event in the center of element rather than x/y -based coordinates (its the edge for rectangles)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use utility to trigger the event in the center of element rather than x/y -based coordinates (its the edge for rectangles)