You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Can you test an rtl language in the demo when switching to rtl mode? E.g. change the legend from "# of votes" to "عدد الاصوات"
Don't see a difference, do you think there should be?
No, after looking into rtl a bit more it seems there should not be a difference.
I was worried that setting ltr might not do the right thing for users in Arabic or Hewbrew. But as far as I can tell this doesn't change anything. The tooltips look like they might not be aligned properly when the user is using an rtl language, but that's the case on master as well. At least this fixes the resize issue
But as far as I can tell this doesn't change anything
direction: rtl is enforced only on the internal div (.chartjs-size-monitor-*) that are used to detect a resize, thus it doesn't impact the canvas or any parent of the canvas or any user DOM elements.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #6057
Demo