Add instructions for image-based tests to the contributors guide#6073
Add instructions for image-based tests to the contributors guide#6073simonbrunel merged 9 commits intochartjs:masterfrom
Conversation
ac45be1 to
bfc55fa
Compare
nagix
left a comment
There was a problem hiding this comment.
This is very helpful for new contributors!
kurkle
left a comment
There was a problem hiding this comment.
Couple of things that sound wrong to me. I also noticed that debug is not needed for new tests, because its going to fail anyway when the png is missing. Only really need debug when trying to figure out why some test doesn't fail, right?
|
You're right. I just tested and |
|
Hi @benmccann, I was using this updated guide to add an image test for a new feature. This guide was pretty easy to follow. I did have just some minor comments to add to this PR. Hopefully they are helpful. |
|
I thin the |
|
Ok. Added a line about the bug option |
04d2566 to
cdb1b9a
Compare
simonbrunel
left a comment
There was a problem hiding this comment.
Thanks @benmccann, I should have wrote these guidelines long time ago :)
This is mostly borrowed from #3988 along with incorporating some info from recent questions asked in the Slack channel