Fix ticks.minor and ticks.major configuration issues#6102
Merged
simonbrunel merged 5 commits intochartjs:masterfrom Apr 2, 2019
Merged
Fix ticks.minor and ticks.major configuration issues#6102simonbrunel merged 5 commits intochartjs:masterfrom
simonbrunel merged 5 commits intochartjs:masterfrom
Conversation
kurkle
previously approved these changes
Mar 1, 2019
etimberg
previously approved these changes
Mar 1, 2019
benmccann
previously approved these changes
Mar 2, 2019
Contributor
benmccann
left a comment
There was a problem hiding this comment.
Thanks for splitting up the PRs. It's much easier to review this way.
I noticed that mergeTicksOptions is called in the time scale. I'm not sure why that is or why it's called both there and in buildOrUpdateControllers. It doesn't seem like logic that should be specific to the time scale and can be removed.
Contributor
Author
|
Regarding |
kurkle
previously approved these changes
Mar 2, 2019
etimberg
previously approved these changes
Mar 2, 2019
benmccann
previously approved these changes
Mar 2, 2019
kurkle
previously approved these changes
Mar 10, 2019
simonbrunel
reviewed
Mar 21, 2019
etimberg
approved these changes
Mar 23, 2019
simonbrunel
approved these changes
Apr 1, 2019
Member
simonbrunel
left a comment
There was a problem hiding this comment.
@nagix Looks great, anything else before merging?
Contributor
Author
|
No, this is ready to merge. |
This was referenced Apr 14, 2020
exwm
pushed a commit
to exwm/Chart.js
that referenced
this pull request
Apr 30, 2021
This was referenced Jun 1, 2021
Open
This was referenced Jul 5, 2021
This was referenced Jul 27, 2021
This was referenced Oct 14, 2021
1 task
This was referenced Jan 21, 2022
This was referenced Feb 4, 2022
This was referenced Mar 7, 2022
Open
1 task
This was referenced Nov 29, 2022
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a fork from #5961 separating the major/minor tick config issues from the rotation and label layout issues.
Problems
scale.ticks.*options at runtime because the scale class copies the minor and major ticks options fromticks.*on the initial chart creation, and it doesn’t update them on the following update calls as the values already exist ([BUG] Can't update scale.ticks.* options at runtime since 2.7.0 #4896).ticks.major.enabledis set tofalseby default, butticks.majoroptions are effective. The behavior should be consistent with theticks.major.enabledsetting.Solutions
mergeTicksOptionsand addsparseTickFontOptionsto parse minor and major tick font options. Omitted options are inherited fromticksat runtime.ticks.major.enabledisfalse.Master: https://jsfiddle.net/nagix/76fLvg8u/

This PR: https://jsfiddle.net/nagix/4n5rd2gz/

Fixes #4896