Skip to content

Fix the missing Chart.Chart (deprecated) alias#6112

Merged
simonbrunel merged 1 commit intochartjs:masterfrom
simonbrunel:chore/chart.chart-alias
Mar 6, 2019
Merged

Fix the missing Chart.Chart (deprecated) alias#6112
simonbrunel merged 1 commit intochartjs:masterfrom
simonbrunel:chore/chart.chart-alias

Conversation

@simonbrunel
Copy link
Member

The Chart.Chart alias has been unintentionally removed in #5969 (existed at this line) but while debugging optional moment in Angular, I found that this alias is still in use.

// GOOD
import Chart from 'chart.js';

// WRONG
import { Chart } from 'chart.js';

@simonbrunel simonbrunel added this to the Version 2.8 milestone Mar 5, 2019
@simonbrunel simonbrunel merged commit 87a74f9 into chartjs:master Mar 6, 2019
@simonbrunel simonbrunel deleted the chore/chart.chart-alias branch March 6, 2019 08:12
@simonbrunel simonbrunel mentioned this pull request Mar 7, 2019
4 tasks
exwm pushed a commit to exwm/Chart.js that referenced this pull request Apr 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants