Merged
Conversation
benmccann
approved these changes
Mar 5, 2019
kurkle
approved these changes
Mar 5, 2019
nagix
approved these changes
Mar 5, 2019
Member
|
Just tested with this project reported in this comment (@lsn793) and it works as expected with: // package.json
{
"browser": {
"moment": false
}
}Thanks @jonrimmer for this find. I also noticed that this project includes Angular projects using the |
exwm
pushed a commit
to exwm/Chart.js
that referenced
this pull request
Apr 30, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This slightly tightens the check for Moment. This is so you can use the browser field to exclude Moment from the bundle (as per #5978). By default, ignoring a module makes it return an empty object, and this was passing the check.