Vertical time scale generates too few ticks

[kurkle]

Vertical time scale generates too few ticks, due to considering tick length in capacity calculation.

This might not be a correct fix however, because the function is called getLabelWidth.

Master: Pen

PR: Pen

With offset: Pen

[benmccann]

getLabelWidth is marked @private so I would be okay renaming it to _getLabelSize

[simonbrunel]

It's marked private but not since the beginning (introduced in v2.6 and made private in v2.7) so not sure it's a good idea to rename it since it doesn't add any benefit.

[simonbrunel]

Though, good point from @kurkle that the returned value isn't anymore the label width for vertical scales. Introducing _getLabelSize (private) returning {w, h} and have getLabelWidth deprecated and be return _getLabelSize().w instead seems a good alternative?

[benmccann]

I want to know how @kurkle got time travel abilities :-)

[kurkle]

Another thing noticed here is that offset is not accounted for in chartArea. Box size is calculated from chartArea in that example, that's why it looks so wrong in master.

[kurkle]

For 2.8.0 this can be worked around by setting maxRotation: 90 on vertical time scale.

[nagix]

If we take into account offset, the code would look like this?

var capacity = Math.floor(me.isHorizontal() ? me.width / size.w : me.height / size.h);

if (me.options.offset) {
    capacity--;
}

return capacity > 0 ? capacity : 1;

[kurkle]

@nagix I think you are right. I'll test that when I have a chance.

[kurkle]

Made @nagix suggestion and then realized its not strictly correct either. If min/max is defined, offset is ignored at that end. Doesn't make a huge difference though.

[nagix]

Ok, this is related to #5618. If everyone agrees that offset should work even when min or max is set, it should be fixed separately.