Skip to content

_autoSkip() in update() instead of draw()#6290

Closed
kurkle wants to merge 1 commit intochartjs:masterfrom
kurkle:autoskip
Closed

_autoSkip() in update() instead of draw()#6290
kurkle wants to merge 1 commit intochartjs:masterfrom
kurkle:autoskip

Conversation

@kurkle
Copy link
Member

@kurkle kurkle commented May 22, 2019

Fixes: #3694

PR

image

Master

image

@kurkle
Copy link
Member Author

kurkle commented May 22, 2019

dud :)

@kurkle kurkle closed this May 22, 2019
@benmccann
Copy link
Contributor

I'm hoping #6274 could be merged first before getting back to this

The one thing I'm worried about is the performance impact. Right now update is called multiple times in fitting the scale whereas draw is only called once, so this change would make the auto-skipper called multiple times

@kurkle kurkle deleted the autoskip branch November 13, 2019 06:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Axis labels removed by the auto skip functionality are still considered for sizing purposes

2 participants