Handle reverse support in core.scale#6343
Conversation
benmccann
left a comment
There was a problem hiding this comment.
I haven't really reviewed yet. I like the idea that we could handle reverse in core.scale. It seems like some of the scales still know about reverse though? E.g. I would have expected if all the logic is being done in core.scale that this PR would be removing reverse from scale.time
This comment has been minimized.
This comment has been minimized.
|
Chart.js/src/core/core.scale.js Lines 73 to 75 in 97f819d lineValue -= Math.max(lineValue - scale._start, scale._end - lineValue);Also, Chart.js/src/core/core.scale.js Line 1137 in 97f819d Chart.js/src/core/core.scale.js Line 1146 in 97f819d scaleLabelX = me.left + me.width / 2; // midpoint of the widthscaleLabelY = me.top + me.height / 2; |
|
Updated, all comments should be resolved. |
|
Added |
benmccann
left a comment
There was a problem hiding this comment.
lgtm. just had one last question
* Move log10 from core.helpers to helpers.math * Refactor scales

_configurescales after placing themticks.reverseingetPixelForDecimalgetDecimalForPixelgetPixelForDecimaland_configureresults in scales-472-403 bytes (much of this by moving helpers.log10)Doing essentially the same thing as #6342, just a bit more abstractly.
Forked fiddle (notice
horizontalBarreverse is reversed compared to 6342)Closes #3306
Closes #6342