Add link back to home page from docs#6435
Merged
etimberg merged 3 commits intochartjs:masterfrom Aug 4, 2019
Merged
Conversation
jacobsorme
changed the title
etimberg
previously approved these changes
Aug 4, 2019
benmccann
reviewed
Aug 4, 2019
docs/SUMMARY.md
Outdated
| @@ -1,5 +1,6 @@ | |||
| # Summary | |||
|
|
|||
| * [←](https://www.chartjs.org) | |||
Contributor
There was a problem hiding this comment.
I think ← might be slightly confusing because it looks like the back button and chartjs.org might not be the last page you visited.
A couple other options:
- Rename the existing "Chart.js" link to "Introduction". Add a new link that says something like "Chart.js" or "Homepage"
- Add a link to the samples instead. That's the only other thing that's on the homepage. It'd be fewer clicks that way because you could go straight to the samples instead of navigating through the homepage
Contributor
Author
There was a problem hiding this comment.
True, you are right. I think both of your options make sense. If you somehow end up on docs without having been on the homepage before then the first option would make more sense. What do you think?
benmccann
reviewed
Aug 4, 2019
docs/SUMMARY.md
Outdated
| # Summary | ||
|
|
||
| * [Chart.js](README.md) | ||
| * [← Chart.js](https://www.chartjs.org) |
Contributor
There was a problem hiding this comment.
I would probably still drop the ← since it's a bit of an uncommon character
benmccann
approved these changes
Aug 4, 2019
etimberg
approved these changes
Aug 4, 2019
This was referenced Mar 4, 2020
This was referenced Mar 9, 2020
This was referenced Apr 14, 2020
exwm
pushed a commit
to exwm/Chart.js
that referenced
this pull request
Apr 30, 2021
* Add link back to home page from docs chartjs#6433 * Modify link texts * Edit homepage link
This was referenced Jun 1, 2021
Open
1 task
This was referenced Jul 5, 2021
This was referenced Jul 27, 2021
This was referenced Oct 14, 2021
1 task
This was referenced Jan 21, 2022
This was referenced Feb 4, 2022
This was referenced Mar 7, 2022
Open
1 task
This was referenced Nov 29, 2022
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Edited
docs/SUMMARY.mdto add the link - is that how the website is generated? See Issue #6433.