Use array spread to push multiple items to labelColors#6438
Use array spread to push multiple items to labelColors#6438RobbieTheWagner wants to merge 2 commits intochartjs:masterfrom
Conversation
Use array spread to push multiple items to labelColors
|
I believe the spread operator does not work in IE11, which is a browser we support |
|
Thanks for the PR. For now, I'm going to close this since it's failing the tests and incompatible with IE. Please feel free to reopen when those issues are addressed |
|
@benmccann do you guys not use babel? |
|
No, we don't |
|
@benmccann any particular reason to not use it? |
|
See #5787 (comment) |
|
@benmccann why not use Babel and just transpile to the targets you want? That comment seems to be concerned about browser support, which is totally doable with Babel. I really need to be able to specify multiple label colors. I can return an array from the |
|
See #6555 for discussion on babel |
I believe this should allow for arrays to be returned from
labelColor. I have not tested it yet, but I am going to now.