Fix : Issue #6455 : steppedline chart stacked with stacked groups does not work properly#6461
Closed
koljagava wants to merge 6 commits intochartjs:masterfrom
Closed
Fix : Issue #6455 : steppedline chart stacked with stacked groups does not work properly#6461koljagava wants to merge 6 commits intochartjs:masterfrom
koljagava wants to merge 6 commits intochartjs:masterfrom
Conversation
benmccann
reviewed
Aug 13, 2019
| * @returns {string[]} The list of stack IDs | ||
| * @private | ||
| */ | ||
| _getStacks: function(last) { |
Contributor
There was a problem hiding this comment.
It looks like this is copied directly from the bar scale (though with meta.bar changed to meta.line). I'm not sure it there's a preferred way of sharing the code, but I'd like to get other folks thoughts on this
Author
There was a problem hiding this comment.
Hi @benmccann,
I did it intentionally to maintain project "coerence". If this solution will be considered valid i can try to do a refactoring making those methods (_getStacks, getStackIndex) available in a common prototype (DatasetController?) and with the ability to choose axis (index or value) to work on.
let me know.
regards
Kolja
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please consider this pull request as a fix for issue #6455
thank you
kolja