Merged
Conversation
4077928 to
7d6984e
Compare
kurkle
reviewed
Oct 30, 2019
Member
kurkle
left a comment
There was a problem hiding this comment.
Couple of suggestions, but I'm good with this implementation too.
This is a good cleanup!
Member
|
I like the direction this is going. I agree with @kurkle's points above. Updating to |
Member
|
I think you can go ahead and fix the tests. |
80e308c to
fe29898
Compare
Contributor
Author
|
Ok. All tests should be passing now |
etimberg
previously approved these changes
Oct 30, 2019
Member
etimberg
left a comment
There was a problem hiding this comment.
I didn't have any complaints.
fe29898 to
7ff8c3c
Compare
kurkle
previously approved these changes
Oct 31, 2019
etimberg
previously approved these changes
Oct 31, 2019
kurkle
approved these changes
Oct 31, 2019
etimberg
approved these changes
Oct 31, 2019
Member
|
shall we merge this? |
Contributor
Author
|
I'm ready if you both are |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #5019
There's a ton of tests that will need to be updated to expect tick objects instead of strings, but otherwise this is mostly working. I wanted to get some feedback before I finish that
A couple things that could be cleaned up:
convertTicksToLabelswould probably be less code if it modified ticks in place to set the labels rather than returning the labels and then havingcore.scaleput the labels on the ticks