Remove index and datasetIndex from Element#6687
Closed
benmccann wants to merge 7 commits intochartjs:masterfrom
Closed
Remove index and datasetIndex from Element#6687benmccann wants to merge 7 commits intochartjs:masterfrom
benmccann wants to merge 7 commits intochartjs:masterfrom
Conversation
Contributor
Author
|
Will open a new PR with the rebased version |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Only review the last commit. The other commits are from #6576, which this depends on. I will rebase it after that PR is committed.
From a developer's point of view, the new APIs are purely more powerful since the interaction methods now return the
datasetIndexandindexas well. Previously these were private variables insideElementRight now
Elementholds a few things that it doesn't really need to. This has a memory impact since anElementis created for every data point and held throughout the life of the chart. Chart.js has relatively high memory requirements compared to some other libraries and I think we can improve our standing on this front.This alone probably doesn't have that large of an impact on performance, but there are additional performance improvements this will unblock that should be very impactful especially in the case that animations are disabled.