Skip to content

Reuse _parsed#6756

Closed
kurkle wants to merge 1 commit intochartjs:masterfrom
kurkle:parse-garbage
Closed

Reuse _parsed#6756
kurkle wants to merge 1 commit intochartjs:masterfrom
kurkle:parse-garbage

Conversation

@kurkle
Copy link
Member

@kurkle kurkle commented Nov 16, 2019

The "what if" part from #6750 (review)

@benmccann
Copy link
Contributor

I'm okay with leaving _parsed under meta.data, but think it would be clearer if we initialized _parsed to undefined and the parsing functions returned new objects instead of setting values in previously created objects

@kurkle
Copy link
Member Author

kurkle commented Nov 17, 2019

@benmccann you're right, it is better to have it undefined to start with, so premature access shows up more easily.

@kurkle kurkle closed this Nov 17, 2019
@kurkle
Copy link
Member Author

kurkle commented Nov 17, 2019

Closed in favor of #6758

@kurkle kurkle deleted the parse-garbage branch February 19, 2020 20:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants