Conversation
kurkle
left a comment
There was a problem hiding this comment.
Ok, this is not required through, you could just set meta.data=dataset.data.
I don't actually think this is a good idea
|
Edit: I'll have to think this more, it feels like we are going towards more trouble. |
|
Ok, one issue here is that we can not know if the said controller creates equal amount of elements with the So I don't think we should make elements optional. |
|
#6831 adds tests to make sure the arrays stay the same size, so I think it's okay to assume. But the code makes that assumption even without this PR by doing: This loop is primarily looping over and doing a calculation on |
kurkle
left a comment
There was a problem hiding this comment.
Fine, we can fix it later if its a problem.
This change would be necessary to allow the
fastlinecontroller from #6822 to be implemented externally