Enable override settings for the axis border#6883
Merged
etimberg merged 2 commits intochartjs:masterfrom Jan 3, 2020
Merged
Conversation
Adds two new options to the cartesian axis: `borderColor` and `borderWidth` which are used to control the border drawn at the edge of the axis area. If these options are not set, the first grid line settings are used.
benmccann
reviewed
Dec 31, 2019
Contributor
benmccann
left a comment
benmccann
left a comment
There was a problem hiding this comment.
Should we add a new option or just suggest to people to use scriptable options? I'm not sure how to think about the tradeoff
kurkle
reviewed
Jan 1, 2020
Member
kurkle
left a comment
kurkle
left a comment
There was a problem hiding this comment.
Other than "colour", looks good to me
kurkle
approved these changes
Jan 1, 2020
kurkle
changed the title
benmccann
approved these changes
Jan 3, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds two new options to the cartesian axis:
borderColorandborderWidthwhich are used to control the border drawn at the edge of the axis area. If these options are not set, the first grid line settings are used.Closes: #4041