Closed
Conversation
etimberg
approved these changes
Jan 23, 2020
Member
|
Shouldn't the |
Contributor
Author
I think there's basically two options which I've outlined in #7009. What you're suggesting is option 1. I prefer option 2 overall though
Good catch. I hadn't thought about the about the fact that we have a custom rollup plugin for importing CSS that our users would need too. I guess this doesn't really work that well if we want to keep that working the same way it does today |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is necessary in order to import just the files you want for tree shaking as proposed in #4461