Conversation
kurkle
previously approved these changes
Jan 30, 2020
kurkle
previously approved these changes
Jan 30, 2020
Contributor
Author
|
Sorry I kept updating this PR. I think this should now be all the JSDoc errors that TypeScript found |
etimberg
previously approved these changes
Jan 31, 2020
awibox
reviewed
Jan 31, 2020
src/helpers/helpers.dom.js
Outdated
| } | ||
|
|
||
| return 'none'; | ||
| return undefined; |
There was a problem hiding this comment.
When the function returns undefined it looks like an error. Why not return null for example?
Contributor
Author
There was a problem hiding this comment.
@kurkle are you okay with returning null here?
Member
There was a problem hiding this comment.
I'd prefer not returning anything (same as returning undefined).
There are some good arguments at SO about this.
Contributor
Author
There was a problem hiding this comment.
The most upvoted answer on the StackOverflow answer says to return null - though that's not the answer the asker chose. null makes sense to me. But I don't really care or think it matters either so I just made it an empty return for now
Contributor
Author
benmccann
force-pushed
the
jsdoc-erros
branch
from
3016f87 to
581341c
Compare
kurkle
approved these changes
Feb 3, 2020
etimberg
approved these changes
Feb 3, 2020
awibox
approved these changes
Feb 3, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.