Conversation
|
Oops. rebasing caused some new errors. |
benmccann
left a comment
benmccann
left a comment
There was a problem hiding this comment.
The changes you made to PluginService, etc. will probably make the typedoc generated for those classes better. There were a couple it was skipping and I imagine this will fix it
I had tried generating types, but I wasn't sure they were that useful. It was just marking everything as type any in my attempt, so I figured the DefinitelyTyped ones would be more useful. That might be able to be fixed by either adding more JSDocs specifying the types or by actually converting the code to be written in TypeScript
gulpfile.js
Outdated
|
|
||
| var pkg = require('./package.json'); | ||
| var tsProject = typescript.createProject('./tsconfig.json'); | ||
| var tsBuild = typescript.createProject('./tsconfig.build.json'); |
There was a problem hiding this comment.
Do we need a new one? Or will it work to just put the new options in the existing tsconfig.json?
There was a problem hiding this comment.
I think it would work.
This way we have linting and building separated, but not sure how useful it is.
kurkle
force-pushed
the
generate-types
branch
3 times, most recently
from
00c15b8 to
4f74824
Compare
|
I'm not sure about actually generating the types because I'm not sure the auto-generated ones are as useful as the handmade ones at DefinitelyTyped, but I like the other changes. Maybe we could split this into two PRs to consider separately? |
kurkle
force-pushed
the
generate-types
branch
from
4f74824 to
472ffa9
Compare
kurkle
force-pushed
the
generate-types
branch
from
472ffa9 to
9705ba4
Compare
2 participants
On top of #7030, add type generation.
It produced initially 3 errors, that are resolved by changing
defaultsandpluginServiceto class declarations, making singleton instance and exporting that, changingdefaults._settodefaults.setand exportingDateAdapter.Also fixed the formatting of gulpfile.js