Allow registering scale with single parameter#7157
Merged
etimberg merged 4 commits intochartjs:masterfrom Feb 28, 2020
Merged
Conversation
benmccann
force-pushed
the
scale-registration
branch
from
0feba2b to
b6805ac
Compare
kurkle
reviewed
Feb 26, 2020
kurkle
previously approved these changes
Feb 26, 2020
etimberg
reviewed
Feb 26, 2020
Member
etimberg
left a comment
etimberg
left a comment
There was a problem hiding this comment.
Will need an update to the documentation in https://github.com/chartjs/Chart.js/blob/master/docs/developers/axes.md
Contributor
Author
|
done |
etimberg
reviewed
Feb 27, 2020
kurkle
approved these changes
Feb 27, 2020
etimberg
approved these changes
Feb 28, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reopening #7009 since it sounds like we might be leaning more towards explicit registration in the tree-shaking case