Merged
Conversation
benmccann
reviewed
May 22, 2020
Contributor
|
|
etimberg
reviewed
May 22, 2020
Member
etimberg
left a comment
etimberg
left a comment
There was a problem hiding this comment.
Removing gulp is a big step! Even better that it fixes some long standing issues.
sgratzl
reviewed
May 24, 2020
sgratzl
reviewed
May 24, 2020
etimberg
reviewed
May 26, 2020
Member
etimberg
left a comment
etimberg
left a comment
There was a problem hiding this comment.
Overall, this is looking great! 😄
I left a 2 minor notes. Looking forward to having this
Review update
Member
Author
There is a packages for that: It could probably be handled in the release script too. |
etimberg
approved these changes
May 27, 2020
benmccann
approved these changes
May 27, 2020
|
i guess it's finally time? ;) https://github.com/chartjs/Chart.js/pull/6835/files#diff-b9cfc7f2cdf78a7f4b91a753d10865a2 |
Contributor
|
thanks for the idea :-) |
3 tasks
etimberg
pushed a commit
that referenced
this pull request
Sep 1, 2020
Gulp removed from toolchain in favour of simpler build process
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace
gulpwith npm scriptsOne big difference is a
.tar.gzis generated instead of.zip.Fixes: #6754 (
npm run dev)