Introduce ability to annotate a single bar

[lukasbischof]

This PR introduces the ability to annotate only a single bar (implementing #101):

It also supports horizontal bars:

The PR adds two new options to the line annotation:

• onlyForDataIndex which specifies the data index which should be annotated
• linePadding which adds a customisable padding to the start and end of the line
• datasetIndex which specifies on which dataset the data should be annotated

[sammeel]

Hi, I came across your answer as I was searching for the same thing. I noticed that your label is always aligned to the graph, not to the line. Is this the intended behavior? For a line across the whole chart, this is the intended behavior, but I would have expected the label to be aligned to line.

For example a center aligned label for dataindex 0 gives me this chart:

I also noticed some variables are being set on the window object, which is probably left from debugging

[lukasbischof]

Hi, thanks for your input. However, I'm not able to reproduce the problem. Centering should actually be supported and if I try to reproduce, it yields this result:

Could you point out how exactly you received this behaviour and where variables on window are set?

[sammeel]

mmm, I must have done something wrong. I just tried reproducing it again, and now it works fine.

My appologies :)

EDIT: found out why. copied the wrong version while going through the commits

[Alex-Sichkar]

Nice feature, thanks! Is there a way to remove line padding at all? If I set linePadding to 0 some padding still there.

[lukasbischof]

@ygwain Actually it should be already like that. Could you provide your code to reproduce?

[Alex-Sichkar]

@lukasbischof https://codepen.io/anon/pen/qLWwbx

[benmccann]

@lukasbischof this PR is currently failing our style guidelines. If you rebase against master you can run gulp lint locally to ensure that everything passes

[lukasbischof]

@ygwain Should be fixed by now. I also inverted the padding, because I think it may be more natural if the padding is an inset spacing considering the behaviour applied in CSS.

[faraonkicu]

Hello, when you are planning to merge this feature?

[Obleo33]

I would love to be able to use this feature. Please merge soon.

[benmccann]

I went back and read through the thread at #141 again. The author of that PR and I had decided a hoverColor option would be a better solution for what he's trying to accomplish. That's fairly different from the original problem being discussed, so sorry for the confusion. Let's consider these PRs separately

I'm going to delete the comments discussing this PR vs #141 to keep the thread clean since they no longer seem relevant

[benmccann]

I think this is too specific to the bar chart. Could you pass a start and end tick and then use scale.getPixelForTick instead of using the bar controller and model?

outdated

[stockiNail]

@kurkle I have seen that these new features are not available on version 1 of the plugin.
Make sense to think implementing them in version1 as well?

[kurkle]

There is a discussion about this: #484

I would not like to add bar specific configuration when its quite easily achieved already.

[kurkle]

But samples would be good.

[stockiNail]

@kurkle thank you ! I haven't seen the discussion.

[stockiNail]

But samples would be good.

I think makes sense. Do you already a list of additional samples (apart this one) you'd like to have in the samples doc section?

[kurkle]

But samples would be good.

I think makes sense. Do you already a list of additional samples (apart this one) you'd like to have in the samples doc section?

No, I don't have a list