Line label font merged with chart.options.font #268
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Conflicts: src/annotation.js
Member
|
this too needs rebase |
Collaborator
Author
doing.. I need time. Wait for a while. |
Conflicts: src/annotation.js src/types/box.js src/types/line.js src/types/point.js
Collaborator
Author
|
rebased |
Member
|
Hmh. Just the sort of things I don't want to have in here. Lets wait with this one (perhaps for chartjs/Chart.js#8008) |
Collaborator
Author
I need to remove this change from the others. I can close this one, ok for u? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #262
Line label font merged with
chart.options.fontin order to inherit the chart options instead ofChart.defaults.fontones.