Skip to content

Use margin option in the callout check for being shown#742

Merged
stockiNail merged 3 commits into
chartjs:masterfrom
pepstock-org:fixCalloutCheck
May 19, 2022
Merged

Use margin option in the callout check for being shown#742
stockiNail merged 3 commits into
chartjs:masterfrom
pepstock-org:fixCalloutCheck

Conversation

@stockiNail
Copy link
Copy Markdown
Collaborator

Fix #741

@stockiNail stockiNail added the bug label May 19, 2022
@stockiNail stockiNail added this to the 2.0.0 milestone May 19, 2022
@kurkle
Copy link
Copy Markdown
Member

kurkle commented May 19, 2022

Not sure what's up with coveralls, but 0% coverage is not acceptable :)

@stockiNail
Copy link
Copy Markdown
Collaborator Author

Not sure what's up with coveralls, but 0% coverage is not acceptable :)

It seems an issue in coveralls
I will have a look later recommitting something

@stockiNail
Copy link
Copy Markdown
Collaborator Author

Not sure what's up with coveralls, but 0% coverage is not acceptable :)

Fixed rebasing ;)

@stockiNail stockiNail merged commit da64e92 into chartjs:master May 19, 2022
@stockiNail stockiNail deleted the fixCalloutCheck branch May 19, 2022 19:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Callout is shown even if box label and the margin is beyond the point

2 participants