Add beforeDraw and afterDraw hooks to the annotations#744
Merged
Conversation
Conflicts: types/options.d.ts
Conflicts: src/annotation.js
kurkle
reviewed
Sep 28, 2022
Member
kurkle
left a comment
There was a problem hiding this comment.
I still don't like the counters
How about making it simpler, just draw before/after the main element is drawn?
We could add afterDrawChildren later, if it's really needed.
Collaborator
Author
I think its reasonable |
Collaborator
Author
done! review applied! No counters anymore! |
kurkle
approved these changes
Jan 26, 2023
Member
kurkle
left a comment
There was a problem hiding this comment.
Sorry for the huge delay on these. LGTM
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is adding before/after draw hooks in order to allow the user to apply whatever needed customization on out-of the-box annotations. Fix #146.
The hooks will be invoked once for every annotation for each drawing cycle.
annotation.beforeDrawannotation.afterDrawCommon hooks for all annotations can be set in the annotation plugin options:
TODO