Change and reorder the types definitions#759
Conversation
LeeLenaleee
left a comment
There was a problem hiding this comment.
Not sure what the reason was behind re exporting string as another type without actually doing something with it but I think this is better and more type safe that what it was before
@LeeLenaleee we have tried in the past that format but it seems is not compatible with some TS version... I'm looking for the comment in a PR |
Co-authored-by: Jacco van den Berg <39033624+LeeLenaleee@users.noreply.github.com>
|
Guess it is anything lower as 4.1 @stockiNail. But since it is a V2 release I guess we can call it a breaking change and require at least TS version 4.1 since 4.1 is already 2 years old EDIT: |
Could make sense for me. If all agree, I need to change this PR in order to
Let me know. As said, for me it's fine. |

This PR is changing the types definitions in order to:
AnnotationCoordinatesbecause adds the options inCoreAnnotationOptionsAnnotationPluginCommonOptionsand changescommonoption defintion to accept a types annotation options