Change CHART.JS dependency to version 4#808
Merged
Merged
Conversation
Collaborator
Author
|
Thank you @kurkle for the example to fix docs build issue. |
LeeLenaleee
previously approved these changes
Nov 16, 2022
kurkle
reviewed
Nov 17, 2022
Member
kurkle
left a comment
kurkle
left a comment
There was a problem hiding this comment.
Looks good, except if I understand the "noDefaultScales" tests right and those are useless tests now?
LeeLenaleee
approved these changes
Nov 17, 2022
kurkle
approved these changes
Nov 17, 2022
Member
kurkle
left a comment
kurkle
left a comment
There was a problem hiding this comment.
Actually for unit tests its better to ise mocked data, so the situation does not change when chart.js changes. But I think this is fine and we can call it integration or functional test :)
Collaborator
Author
|
Ok @kurkle |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #807