Update packaging to match main chart.js library#815
Conversation
kurkle
left a comment
There was a problem hiding this comment.
Looks ok, but donwe really want to rename the umd files?
|
@kurkle I wen back to the original version, without using UMD in the dist files, as shared. Let me know if it's ok and if yes, let me know if you think we should publish new version 2.1.1 (bumping). |
| "main": "dist/chartjs-plugin-annotation.js", | ||
| "module": "dist/chartjs-plugin-annotation.esm.js", | ||
| "type": "module", | ||
| "main": "dist/chartjs-plugin-annotation.esm.js", |
There was a problem hiding this comment.
If we want to support chart.js v3 on node/commonjs with these later annotation plugin versions, this needs to be umd build with .cjs extension
Something like I did in autocolors: https://github.com/kurkle/chartjs-plugin-autocolors/blob/main/package.json
There was a problem hiding this comment.
Ok Let me update in next hours
Dropping is fine by me, but should definitely be a major version release |
@etimberg ok that means all plugins/controllers in chartjs org must publish a major version for chartjs 4 compatibility, doesn’t it? |
I don't think it's mandatory if the plugin packaging doesn't change |
|
There could be some benefits to from |
Fix #814