Replace chart.min.js by chart.umd.js#916
Merged
Merged
Conversation
There is no "chart.min.js" file when you "npm install chart.js". I supposed it has been replaced by "chart.umd.js" as indicated in the Chart.js integration documentation.
stockiNail
reviewed
Nov 11, 2023
Collaborator
stockiNail
left a comment
stockiNail
left a comment
There was a problem hiding this comment.
I would suggest to user chart.umd.min.js
Contributor
Author
|
But there is currently no |
Collaborator
|
Ok, accessing to CDN by script tag, you can use also umd.min. But that's ok. |
stockiNail
approved these changes
Nov 11, 2023
Collaborator
|
Thanks @JimmyGouraud |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There is no
chart.min.jsfile when younpm install chart.js. I supposed it has been replaced bychart.umd.jsas indicated in the Chart.js integration documentation.