Skip to content

Fix init option (initial animation) type#942

Merged
stockiNail merged 2 commits into
chartjs:masterfrom
fteamkr:patch-1
Sep 19, 2024
Merged

Fix init option (initial animation) type#942
stockiNail merged 2 commits into
chartjs:masterfrom
fteamkr:patch-1

Conversation

@fteamkr
Copy link
Copy Markdown
Contributor

@fteamkr fteamkr commented Sep 19, 2024

Fix "Initial animation" option (init) type by document (https://www.chartjs.org/chartjs-plugin-annotation/latest/guide/configuration.html#initial-animation).

And init's return type might be Partial.

I created this PR not a issue, because it might be a simple fix. Thank you!

@stockiNail stockiNail added the types Typescript type changes label Sep 19, 2024
@stockiNail stockiNail added this to the 3.1.0 milestone Sep 19, 2024
@stockiNail
Copy link
Copy Markdown
Collaborator

@fteamkr thank you! Can you rebase the branch?

@stockiNail stockiNail merged commit a8dc07b into chartjs:master Sep 19, 2024
@fteamkr fteamkr deleted the patch-1 branch September 19, 2024 11:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

types Typescript type changes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants