Use less usize
#7573
Merged
Use less usize
#7573
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It is possible to send more than 4 GiB into network stream or receive more than 4 GiB from it, in which case this counter may overflow.
link2xt
force-pushed
the
link2xt/less-usize
branch
from
5211cd2 to
a2d57d4
Compare
adbenitez
approved these changes
Dec 6, 2025
iequidoo
approved these changes
Dec 7, 2025
| /// and <https://users.rust-lang.org/t/cant-convert-usize-to-u64/6243> | ||
| /// and <https://github.com/rust-lang/rust/issues/106050>. | ||
| pub(crate) fn usize_to_u64(v: usize) -> u64 { | ||
| u64::try_from(v).unwrap_or(u64::MAX) |
Collaborator
There was a problem hiding this comment.
Maybe just unwrap()? Panics that can't really happen should be fine
Collaborator
Author
There was a problem hiding this comment.
The problem with adding unwrap() in places that cannot happen is that once the app without debug info crashes on a phone for some user, you now need to look at all the places which may panic. E.g. you add 100 unwraps(), get one wrong and it actually panics, and then you need to review 100 places. This also includes all the dependencies, so if some dependency crashes with .unwrap(), if we don't have .unwrap() in our code we can immediately know that this is not caused by our own code.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to #7572