-
Notifications
You must be signed in to change notification settings - Fork 45
feat: Add 'Restart From Local Devfile' action #185
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add 'Restart From Local Devfile' action #185
Conversation
|
Pull Request images published ✨ |
azatsarynnyy
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tested it by changing the command's ID in the devfile.yaml.
After restarting the DevWorkspace with a new command, the changes were applied to the DW.
Signed-off-by: Roman Nikitenko <rnikiten@redhat.com>
Signed-off-by: Roman Nikitenko <rnikiten@redhat.com>
0673982 to
6b62918
Compare
|
I've added a new commit to improve handling errors at |
|
Pull Request images published ✨ |
|
Build 3.6 :: code_3.x/452: Console, Changes, Git Data |
|
Build 3.6 :: sync-to-downstream_3.x/2651: Console, Changes, Git Data |
| "stopWorkspaceCommand": "Eclipse Che: Stop Workspace", | ||
| "restartWorkspaceCommand": "Eclipse Che: Restart Workspace" | ||
| "restartWorkspaceCommand": "Eclipse Che: Restart Workspace", | ||
| "restartWorkspaceFromLocalDevfileCommand": "Eclipse Che: Restart Workspace From Local Devfile" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ideally, the preposition would not be capitalized:
"Eclipse Che: Restart Workspace from Local Devfile"
| newContent.devWorkspace.spec!.template!.projects = projects; | ||
| await devfileService.updateDevfile(newContent.devWorkspace.spec?.template); | ||
| } else { | ||
| throw new Error('An error occurred while performing generation a new devfile context'); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
->
An error occurred while generating new devfile context
| } | ||
|
|
||
| if (!devfileExists) { | ||
| throw new Error(`The devfile was not found by path: ${devfilePath}`); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
->
The devfile was not found at:
What does this PR do?
Add 'Restart From Local Devfile' action
What issues does this PR fix?
eclipse-che/che#18670
How to test this PR?
Restart From Local devfileaction of theEclipse Chestatus bar item to restart a workspace