Skip to content

Conversation

@le-cong
Copy link
Contributor

@le-cong le-cong commented Oct 3, 2025

Fixes #133

@le-cong le-cong self-assigned this Oct 3, 2025
@le-cong le-cong added the MINOR label Oct 3, 2025
Copilot AI review requested due to automatic review settings October 3, 2025 23:06
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR introduces a new ESLint rule require-consistent-read that enforces proper usage of the ConsistentRead option in AWS DynamoDB read operations to improve service robustness.

  • Creates a new rule that validates ConsistentRead usage in DynamoDB commands
  • Requires ConsistentRead: true for table reads and ConsistentRead: false for global secondary index reads
  • Adds comprehensive test coverage and documentation for the new rule

Reviewed Changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 5 comments.

Show a summary per file
File Description
src/index.ts Registers the new rule in plugin exports and configuration presets
src/aws/require-consistent-read.ts Implements the core rule logic for validating ConsistentRead usage
src/aws/require-consistent-read.spec.ts Provides comprehensive test cases for valid and invalid scenarios
package.json Bumps version to 7.15.0 for the new rule release
docs/rules/require-consistent-read.md Documents the rule with examples of failing and passing code

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Copilot AI review requested due to automatic review settings October 3, 2025 23:21
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 5 out of 6 changed files in this pull request and generated 4 comments.


Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Copilot AI review requested due to automatic review settings October 4, 2025 01:45
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 5 out of 6 changed files in this pull request and generated 2 comments.


Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@le-cong le-cong requested review from carlansley and jpolavar October 6, 2025 14:57
Copy link
Contributor

@jpolavar jpolavar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lftm

@github-actions
Copy link

github-actions bot commented Oct 6, 2025

❌ PR review status - has 1 reviewer outstanding

Copilot AI review requested due to automatic review settings October 6, 2025 21:05
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 8 out of 9 changed files in this pull request and generated 1 comment.


Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@github-actions
Copy link

github-actions bot commented Oct 6, 2025

Beta Published - Install Command: npm install @checkdigit/eslint-plugin@7.16.0-PR.136-d0cb

@le-cong le-cong requested a review from jpolavar October 6, 2025 21:46
@le-cong
Copy link
Contributor Author

le-cong commented Oct 6, 2025

@jpolavar can you review again? i had to merge with main with some minor refactoring.

Copy link
Contributor

@jpolavar jpolavar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lftm

@le-cong le-cong merged commit f7bb3e0 into main Oct 7, 2025
9 checks passed
@le-cong le-cong deleted the consistent-read branch October 7, 2025 20:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

consistentRead should be true unless index is used

4 participants