-
Notifications
You must be signed in to change notification settings - Fork 0
create new rule require-consistent-read #136
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR introduces a new ESLint rule require-consistent-read that enforces proper usage of the ConsistentRead option in AWS DynamoDB read operations to improve service robustness.
- Creates a new rule that validates
ConsistentReadusage in DynamoDB commands - Requires
ConsistentRead: truefor table reads andConsistentRead: falsefor global secondary index reads - Adds comprehensive test coverage and documentation for the new rule
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| src/index.ts | Registers the new rule in plugin exports and configuration presets |
| src/aws/require-consistent-read.ts | Implements the core rule logic for validating ConsistentRead usage |
| src/aws/require-consistent-read.spec.ts | Provides comprehensive test cases for valid and invalid scenarios |
| package.json | Bumps version to 7.15.0 for the new rule release |
| docs/rules/require-consistent-read.md | Documents the rule with examples of failing and passing code |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Copilot reviewed 5 out of 6 changed files in this pull request and generated 4 comments.
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Copilot reviewed 5 out of 6 changed files in this pull request and generated 2 comments.
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
jpolavar
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lftm
|
❌ PR review status - has 1 reviewer outstanding |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Copilot reviewed 8 out of 9 changed files in this pull request and generated 1 comment.
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
…evel client stuff
|
Beta Published - Install Command: |
|
@jpolavar can you review again? i had to merge with main with some minor refactoring. |
jpolavar
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lftm
Fixes #133