Skip to content

Conversation

@adcreare
Copy link
Contributor

@adcreare adcreare commented Oct 5, 2022

Closes #12
Implements:

  • All in one command instead of stages
  • drop the use of publish and rely on tsc only
  • copy all non-typescript files to dist
  • Get source maps working
  • require the files property in package.json

Example usage over in ping PR https://github.com/checkdigit/ping/pull/29

@adcreare adcreare added the MINOR label Oct 5, 2022
@adcreare adcreare requested a review from carlansley October 5, 2022 02:26
Copy link
Contributor

@carlansley carlansley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice, like it. just one minor comment.

@adcreare
Copy link
Contributor Author

Bunch of fixes

  • Removed command file completely
  • src folder is now included in package (I also parse the package.json files property and add /src/ there if it doesn't exist
  • src folder is cleaned so only .ts files and swagger.yml files exist (exclusing everything else including .test.ts and .spec.ts files)

Ready for another look.

@adcreare adcreare requested a review from carlansley October 10, 2022 22:26
Copy link
Contributor

@carlansley carlansley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, one minor issue re the logging

@github-actions
Copy link

Coverage after merging publish-beta-all-in-one into main will be

59.36%▾ -0.59%

Coverage Report
FileStmtsBranchesFuncsLinesUncovered Lines
src/coverage-reporter
   cli.ts0%0%0%0%10, 12–13, 16, 18–19, 21–22, 25, 25–26, 29, 38, 42, 44, 46, 8–9
   comment.ts0%0%0%0%10, 12, 14–16, 16–17, 17, 23, 23, 29–30, 30–31, 34–37, 37, 37–38, 38, 38, 38, 38, 40–41, 41–42, 42, 48, 48, 8
   delete-old-comments.ts0%0%0%0%13, 20–23, 25, 34–36, 36–37, 41, 43, 43, 43, 43, 43, 49, 54–57, 59, 67, 8
   get-changes.ts0%0%0%0%12, 17, 17, 17, 17–18, 21, 29, 29–30, 37, 37, 37–38, 38, 38–39, 8
   html.ts100%100%100%100%
   index.ts0%0%0%0%100–101, 11–12, 14–17, 19, 21, 24–26, 26, 26–27, 27, 27–31, 33–34, 34, 36–37, 40, 40, 40–41, 41, 41, 41, 43, 46, 52, 52, 52–57, 57–60, 63–64, 66, 66–67, 70–72, 74, 74–75, 78, 78, 78–79, 8, 86, 86–87, 9, 98
   lcov.ts83.12%73.68%75%87.04%117, 119–120, 120, 120, 120–122, 124, 126, 134, 83
   tabulate.ts100%100%100%100%
   util.ts100%100%100%100%
src/nocks
   github.test.ts100%100%100%100%
src/publish-beta
   compile.ts0%100%0%0%10–13, 3–5, 7, 9
   files.ts90.91%85.71%100%90.91%28–30
   github.ts86.36%73.68%100%90.91%26, 32, 34–36, 38, 53–55
   index.ts0%100%0%0%10–11, 13–15, 17–21, 24, 26, 28, 3, 33, 35, 4–5, 7–9
   package.ts97.22%100%100%96.67%36
   publish.ts0%100%0%0%10–13, 3–5, 7, 9
   short-id.ts100%100%100%100%

@adcreare
Copy link
Contributor Author

Yup! Done - ready for another look

@adcreare adcreare requested a review from carlansley October 13, 2022 01:31
@carlansley carlansley merged commit 245ffa6 into main Oct 13, 2022
@carlansley carlansley deleted the publish-beta-all-in-one branch October 13, 2022 02:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

publish-beta action - all in one command

3 participants