Skip to content

Conversation

@lukebrdn
Copy link
Contributor

@lukebrdn lukebrdn commented Feb 24, 2023

Resolves #30

@github-actions
Copy link

Coverage after merging allow-aws-sdk/types into main will be

59.47% 0.00%

Coverage Report
FileStmtsBranchesFuncsLinesUncovered Lines
src/check-imports
   index.ts0%0%0%0%10–11, 13, 15–17, 17–19, 21–22, 22–23, 3, 34, 36, 38, 4, 43, 45, 6–7, 9
   package-lock-file-util.ts100%100%100%100%
   packages-not-allowed.ts100%100%100%100%
src/coverage-reporter
   cli.ts0%0%0%0%10, 12–13, 16, 18–19, 21–22, 25, 25–26, 29, 38, 42, 44, 46, 8–9
   comment.ts0%0%0%0%10, 12, 14–16, 16–17, 17, 23, 23, 29–30, 30–31, 34–37, 37, 37–38, 38, 38, 38, 38, 40–41, 41–42, 42, 48, 48, 8
   delete-old-comments.ts0%0%0%0%13, 20–23, 25, 34–36, 36–37, 41, 43, 43, 43, 43, 43, 49, 54–57, 59, 67, 8
   get-changes.ts0%0%0%0%12, 17, 17, 17, 17–18, 21, 29, 29–30, 37, 37, 37–38, 38, 38–39, 8
   html.ts100%100%100%100%
   index.ts0%0%0%0%100–101, 11–12, 14–17, 19, 21, 24–26, 26, 26–27, 27, 27–31, 33–34, 34, 36–37, 40, 40, 40–41, 41, 41, 41, 43, 46, 52, 52, 52–57, 57–60, 63–64, 66, 66–67, 70–72, 74, 74–75, 78, 78, 78–79, 8, 86, 86–87, 9, 98
   lcov.ts83.12%73.68%75%87.04%117, 119–120, 120, 120, 120–122, 124, 126, 134, 83
   tabulate.ts100%100%100%100%
   util.ts100%100%100%100%
src/nocks
   github.test.ts100%100%100%100%
src/publish-beta
   compile.ts0%100%0%0%10–13, 3–5, 7, 9
   files.ts90.91%85.71%100%90.91%28–30
   github.ts86.36%73.68%100%90.91%26, 32, 34–36, 38, 53–55
   index.ts0%100%0%0%10–11, 13–15, 17–21, 24, 26, 28, 3, 33, 35, 4–5, 7–9
   package.ts92.50%66.67%100%93.94%22–23, 41
   publish.ts72.22%100%50%75%23–26

@lukebrdn lukebrdn requested a review from ramaghanta February 24, 2023 17:53
['@aws-sdk/credential-provider-ini', '>3.193.0'],
['@aws-sdk/credential-provider-node', '>3.193.0'],
['@aws-sdk/smithy-client', '>3.193.0'],
['@aws-sdk/types', '>3.193.0'],
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we remove the other aws-sdk dependencies too?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we can because aws-nock doesn't support some of the changes that sdk > 3.193 introduces.
I think we need to fix those before we push this higher.

@ramaghanta
Copy link
Contributor

@lukebrdn missing label. Also adding @adcreare who's the best person to look at this PR

@ramaghanta ramaghanta requested a review from adcreare February 24, 2023 18:35
@lukebrdn
Copy link
Contributor Author

@lukebrdn missing label. Also adding @adcreare who's the best person to look at this PR

I was curious about that. I don't believe past PRs included a label. Not to say we shouldn't start.

@ramaghanta
Copy link
Contributor

@lukebrdn missing label. Also adding @adcreare who's the best person to look at this PR

I was curious about that. I don't believe past PRs included a label. Not to say we shouldn't start.

sorry, my bad. there is no publishing for this repository. So, no need for a label.

Copy link
Contributor

@adcreare adcreare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lukebrdn lukebrdn requested a review from ramaghanta February 27, 2023 15:35
Copy link
Contributor

@ramaghanta ramaghanta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@lukebrdn lukebrdn merged commit 30871b4 into main Feb 27, 2023
@lukebrdn lukebrdn deleted the allow-aws-sdk/types branch February 27, 2023 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

remove aws-sdk/types from not-allowed list

4 participants