-
Notifications
You must be signed in to change notification settings - Fork 0
removed aws-sdk/types from not-allowed list #31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Coverage after merging allow-aws-sdk/types into main will be
Coverage Report |
| ['@aws-sdk/credential-provider-ini', '>3.193.0'], | ||
| ['@aws-sdk/credential-provider-node', '>3.193.0'], | ||
| ['@aws-sdk/smithy-client', '>3.193.0'], | ||
| ['@aws-sdk/types', '>3.193.0'], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should we remove the other aws-sdk dependencies too?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think we can because aws-nock doesn't support some of the changes that sdk > 3.193 introduces.
I think we need to fix those before we push this higher.
adcreare
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
ramaghanta
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Resolves #30