Skip to content

Conversation

@adcreare
Copy link
Contributor

@adcreare adcreare commented May 25, 2023

Closes #43
Closes #44
Closes #47

I've tried to keep the actions seperate and self contained, not sure if that's a good approach, open to ideas if we should consolidate some operations (like the github operations) that are used by a bunch of actions.

@adcreare adcreare marked this pull request as ready for review May 31, 2023 10:01
@adcreare adcreare added the MINOR label May 31, 2023
@adcreare adcreare requested a review from carlansley May 31, 2023 10:01
@carlansley
Copy link
Contributor

Could be in another PR, but also added #46 which I think we need as well.

@adcreare
Copy link
Contributor Author

adcreare commented Jun 7, 2023

Ok I think this PR is probably grown large enough.. its what hash is using at the moment.
When we're happy with this I'll update the PR in hash two switch this over to main.

@adcreare adcreare requested a review from carlansley June 7, 2023 02:39
@github-actions
Copy link

github-actions bot commented Jun 7, 2023

Coverage after merging prepare-beta into main will be

56.10%▾ -3.64%

Coverage Report
FileStmtsBranchesFuncsLinesUncovered Lines
src/check-imports
   index.ts0%0%0%0%10–11, 13, 15–17, 17–19, 21–22, 22–23, 3, 34, 36, 38, 4, 43, 45, 6–7, 9
   package-lock-file-util.ts100%100%100%100%
   packages-not-allowed.ts100%100%100%100%
src/check-pr-reviews
   index.ts0%0%0%0%10–12, 14–15, 15, 17, 17, 17–18, 22–23, 26, 28, 28, 3, 30, 30, 30, 36, 4, 40–41, 44, 5, 50, 52, 54, 59, 61, 7–8
src/comment-npm-publish
   index.ts0%100%0%0%10–11, 13–15, 19, 22, 24, 26, 3, 31, 33, 4–5, 7, 9
src/coverage-reporter
   cli.ts0%0%0%0%10, 12–13, 16, 18–19, 21–22, 25, 25–26, 29, 38, 42, 44, 46, 8–9
   comment.ts0%0%0%0%10, 12, 14–16, 16–17, 17, 23, 23, 29–30, 30–31, 34–37, 37, 37–38, 38, 38, 38, 38, 40–41, 41–42, 42, 48, 48, 8
   delete-old-comments.ts0%0%0%0%13, 20–23, 25, 34–36, 36–37, 41, 43, 43, 43, 43, 43, 49, 54–57, 59, 67, 8
   get-changes.ts0%0%0%0%12, 17, 17, 17, 17–18, 21, 29, 29–30, 37, 37, 37–38, 38, 38–39, 8
   html.ts100%100%100%100%
   index.ts0%0%0%0%100–101, 11–12, 14–17, 19, 21, 24–26, 26, 26–27, 27, 27–31, 33–34, 34, 36–37, 40, 40, 40–41, 41, 41, 41, 43, 46, 52, 52, 52–57, 57–60, 63–64, 66, 66–67, 70–72, 74, 74–75, 78, 78, 78–79, 8, 86, 86–87, 9, 98
   lcov.ts83.12%73.68%75%87.04%125, 127–128, 128, 128, 128–130, 132, 134, 143, 83
   tabulate.ts100%100%100%100%
   util.ts100%100%100%100%
src/github-api
   index.ts76.80%64.71%100%80%109–111, 116–118, 132–134, 139–141, 152–154, 166–167, 35, 41, 43–45, 47, 65–67, 84–85, 87
src/nocks
   github.test.ts91.30%100%83.33%94.12%29
src/prepare-beta
   index.ts0%100%0%0%10–13, 16, 18, 20, 25, 27, 3–5, 7, 9
   package.ts92%0%100%95.45%21–22
src/publish-beta
   compile.ts0%100%0%0%10–13, 3–5, 7, 9
   files.ts91.18%87.50%100%90.91%28–30
   index.ts0%100%0%0%10–11, 13–15, 17–21, 27, 29, 3, 31, 36, 38, 4–5, 7–9
   package.ts93.94%50%100%96.43%22–23
   publish.ts72.22%100%50%75%23–26

@adcreare
Copy link
Contributor Author

adcreare commented Jun 7, 2023

Ready for another look!

@adcreare adcreare requested a review from carlansley June 7, 2023 23:08
@adcreare adcreare merged commit be40856 into main Jun 7, 2023
@adcreare adcreare deleted the prepare-beta branch June 7, 2023 23:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

3 participants