Skip to content

Conversation

@le-cong
Copy link
Contributor

@le-cong le-cong commented Jan 25, 2024

Fixes #70

@le-cong le-cong added the PATCH label Jan 25, 2024
@le-cong le-cong self-assigned this Jan 25, 2024
@github-actions
Copy link

Coverage after merging allow-esm-only-package-import into main will be

50.78%▾ -0.13%

Coverage Report
FileStmtsBranchesFuncsLinesUncovered Lines
src/check-imports
   index.ts0%0%0%0%10–11, 13, 15–17, 17–19, 21–22, 22–23, 3, 34, 36, 38, 4, 43, 45, 6–7, 9
   package-lock-file-util.ts100%100%100%100%
   packages-not-allowed.ts100%100%100%100%
src/check-label
   check-label.ts92.98%77.78%100%95.56%62–63, 71–72
   index.ts0%100%0%0%11, 16, 18, 3, 5, 7, 9
src/check-pr-reviews
   index.ts0%0%0%0%10–12, 14–15, 15, 17, 17, 17–18, 22–23, 26, 28, 28, 3, 30, 30, 30, 36, 4, 40–41, 44, 5, 50, 52, 54, 59, 61, 7–8
src/check-published
   index.ts0%0%0%0%10, 12, 14, 20–22, 26–27, 3, 30–31, 33–34, 36–39, 4, 42, 46–47, 49, 5, 50–51, 54, 56, 56–59, 6, 63, 65, 67, 7, 72, 74, 8
   slack.ts0%100%0%0%20–24, 3, 30–31, 35–36, 4, 45, 48–49, 5, 58, 7
src/comment-npm-publish
   index.ts0%100%0%0%10–11, 13–15, 19, 22, 24, 26, 3, 31, 33, 4–5, 7, 9
src/coverage-reporter
   cli.ts0%0%0%0%10, 12–13, 16, 18–19, 21–22, 25, 25–26, 29, 38, 42, 44, 46, 8–9
   comment.ts0%0%0%0%10, 12, 14–16, 16–17, 17, 23, 23, 29–30, 30–31, 34–37, 37, 37–38, 38, 38, 38, 38, 40–41, 41–42, 42, 48, 48, 8
   delete-old-comments.ts0%0%0%0%13, 20–23, 25, 34–36, 36–37, 41, 43, 43, 43, 43, 43, 49, 54–57, 59, 67, 8
   get-changes.ts0%0%0%0%12, 17, 17, 17, 17–18, 21, 29, 29–30, 37, 37, 37–38, 38, 38–39, 8
   html.ts100%100%100%100%
   index.ts0%0%0%0%100–101, 11–12, 14–17, 19, 21, 24–26, 26, 26–27, 27, 27–31, 33–34, 34, 36–37, 40, 40, 40–41, 41, 41, 41, 43, 46, 52, 52, 52–57, 57–60, 63–64, 66, 66–67, 70–72, 74, 74–75, 78, 78, 78–79, 8, 86, 86–87, 9, 98
   lcov.ts83.12%73.68%75%87.04%125, 127–128, 128, 128, 128–130, 132, 134, 143, 83
   tabulate.ts100%100%100%100%
   util.ts100%100%100%100%
src/github-api
   index.ts73.33%56.10%100%77.39%109–111, 134–136, 153–154, 156, 178–180, 185–187, 201–203, 208–210, 222–224, 236–237, 244–245, 248–249, 49, 55, 57–59, 61, 70–72, 77–79, 95–96
src/nocks
   github.test.ts86.84%100%80%88.89%131, 137, 32
src/perform-bundle
   analyze.ts0%0%0%0%11–13, 16–17, 17–18, 20, 24–25, 25–26, 28, 3, 31, 7–9
   deployer.ts0%100%0%0%11–17, 3–5, 7, 9
   index.ts0%100%0%0%10, 12, 15, 19–21, 23–24, 28–29, 3, 30–33, 4, 41, 43, 45, 5, 50, 52, 8–9
src/prepare-beta
   index.ts0%100%0%0%10–13, 16, 18, 20, 25, 27, 3–5, 7, 9
   package.ts92%0%100%95.45%21–22
src/publish-beta
   compile.ts0%100%0%0%10–13, 3–5, 7, 9
   files.ts91.18%87.50%100%90.91%28–30
   index.ts0%100%0%0%10–11, 13–15, 17–21, 27, 29, 3, 31, 36, 38, 4–5, 7–9
   package.ts93.94%50%100%96.43%22–23
   publish.ts72.22%100%50%75%23–26

Copy link
Contributor

@adcreare adcreare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@le-cong le-cong merged commit 766205b into main Jan 26, 2024
@le-cong le-cong deleted the allow-esm-only-package-import branch January 26, 2024 02:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

remove limitation of upgrading to ESM only packages

3 participants