-
Notifications
You must be signed in to change notification settings - Fork 0
skip check published action for template repository and new repositories created from template #89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
skip check published action for template repository and new repositories created from template #89
Conversation
…ies created from template
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR updates the check-published action to ignore template repositories and bumps the package version.
- Skips running the check if the package name contains "template".
- Updates the package version in package.json from "2.4.0" to "2.4.1".
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/check-published/check-published.ts | Added a block to skip the check if the package name includes "template". |
| package.json | Version bump to reflect the updated package version. |
|
|
||
| log(`Main package.json - name ${mainPackageJson.name} - version ${mainPackageJson.version}`); | ||
|
|
||
| if (mainPackageJson.name.includes('template')) { |
Copilot
AI
Jun 2, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[nitpick] Consider normalizing the package name with toLowerCase() if there is any possibility of encountering uppercase letters, ensuring the check for 'template' is case insensitive.
| if (mainPackageJson.name.includes('template')) { | |
| if (mainPackageJson.name.toLowerCase().includes('template')) { |
|
Coverage after merging skip-check-published-for-templates-and-new-repos into main will be
Coverage Report |
|
✅ PR review status - All reviews completed and approved! |
closes #88