Skip to content

Conversation

@ramaghanta
Copy link
Contributor

closes #88

@ramaghanta ramaghanta requested a review from Copilot June 2, 2025 19:25
@ramaghanta ramaghanta self-assigned this Jun 2, 2025
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the check-published action to ignore template repositories and bumps the package version.

  • Skips running the check if the package name contains "template".
  • Updates the package version in package.json from "2.4.0" to "2.4.1".

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

File Description
src/check-published/check-published.ts Added a block to skip the check if the package name includes "template".
package.json Version bump to reflect the updated package version.


log(`Main package.json - name ${mainPackageJson.name} - version ${mainPackageJson.version}`);

if (mainPackageJson.name.includes('template')) {
Copy link

Copilot AI Jun 2, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[nitpick] Consider normalizing the package name with toLowerCase() if there is any possibility of encountering uppercase letters, ensuring the check for 'template' is case insensitive.

Suggested change
if (mainPackageJson.name.includes('template')) {
if (mainPackageJson.name.toLowerCase().includes('template')) {

Copilot uses AI. Check for mistakes.
@github-actions
Copy link

github-actions bot commented Jun 2, 2025

Coverage after merging skip-check-published-for-templates-and-new-repos into main will be

59.76%▾ -0.19%

Coverage Report
FileStmtsBranchesFuncsLinesUncovered Lines
src/check-imports
   check-imports.ts0%0%0%0%1, 1, 10–19, 2, 20–29, 3, 30–38, 4–9
   index.ts0%0%0%0%1, 1–5
   package-lock-file-util.ts100%100%100%100%
   packages-not-allowed.ts100%100%100%100%
src/check-label
   check-label.ts94.23%89.47%100%95.12%62–64, 71–73
   index.ts0%0%0%0%1, 1–5
src/check-pr-reviews
   check-pr-reviews.ts0%0%0%0%1, 1, 10–19, 2, 20–29, 3, 30–39, 4, 40–49, 5, 50, 6–9
   index.ts0%0%0%0%1, 1–5
src/check-published
   check-published.ts0%0%0%0%1, 1, 10–19, 2, 20–29, 3, 30–39, 4, 40–49, 5, 50–59, 6, 60–69, 7, 70–72, 8–9
   index.ts0%0%0%0%1, 1–5
   slack.ts0%0%0%0%1, 1, 10–19, 2, 20–29, 3, 30–39, 4, 40–49, 5, 50–59, 6–9
src/comment-npm-publish
   comment-npm-publish.ts0%0%0%0%1, 1, 10–19, 2, 20–22, 3–9
   index.ts0%0%0%0%1, 1–5
src/coverage-reporter
   cli.ts0%0%0%0%1, 1, 10–19, 2, 20–29, 3, 30–39, 4, 40–49, 5, 50, 6–9
   comment.ts0%0%0%0%1, 1, 10–19, 2, 20–29, 3, 30–39, 4, 40–49, 5, 50–52, 6–9
   coverage-reporter.ts0%0%0%0%1, 1, 10, 100–109, 11, 110–111, 12–19, 2, 20–29, 3, 30–39, 4, 40–49, 5, 50–59, 6, 60–69, 7, 70–79, 8, 80–89, 9, 90–99
   delete-old-comments.ts0%0%0%0%1, 1, 10–19, 2, 20–29, 3, 30–39, 4, 40–49, 5, 50–59, 6, 60–69, 7, 70–72, 8–9
   get-changes.ts0%0%0%0%1, 1, 10–19, 2, 20–29, 3, 30–39, 4, 40–41, 5–9
   html.ts100%100%100%100%
   index.ts0%0%0%0%1, 1–5
   lcov.ts93.97%90%100%94.32%122–132, 139
   options.ts0%0%0%0%1, 1, 10–14, 2–9
   tabulate.ts99.56%97.96%100%100%159
   util.ts100%100%100%100%
src/github-api
   index.ts80.42%68.42%100%82.42%109–112, 134–137, 156–165, 180–183, 187–190, 203–206, 210–213, 224–227, 238–240, 246–248, 250–253, 49, 55, 57–61, 70–73, 77–80, 95–97
src/nocks
   github.test.ts98.95%90.91%100%99.44%164, 64
src/perform-bundle
   analyze.ts0%0%0%0%1, 1, 10–19, 2, 20–29, 3, 30–36, 4–9
   deployer.ts0%0%0%0%1, 1, 10–18, 2–9
   index.ts0%0%0%0%1, 1–5
   perform-bundle.ts0%0%0%0%1, 1, 10–19, 2, 20–29, 3, 30–39, 4, 40–42, 5–9
src/prepare-beta
   index.ts0%0%0%0%1, 1–5
   package.ts93.33%66.67%100%95%22–24
   prepare-beta.ts0%0%0%0%1, 1, 10–17, 2–9
src/publish-beta
   compile.ts0%0%0%0%1, 1, 10–14, 2–9
   files.ts92.86%91.67%100%92.86%28–31
   index.ts0%0%0%0%1, 1–5
   package.ts94.92%83.33%100%96%22–24
   publish-beta.ts0%0%0%0%1, 1, 10–19, 2, 20–28, 3–9
   publish.ts82.35%100%50%82.76%25–29
   validate-name-and-resource-length.ts89.08%100%50%88.30%35–38, 88–94
src/validate-npm-package
   index.ts0%0%0%0%1, 1–5
   validate-npm-package.ts98.35%77.78%100%100%47, 53

@ramaghanta ramaghanta requested a review from carlansley June 2, 2025 19:37
@github-actions
Copy link

github-actions bot commented Jun 2, 2025

✅ PR review status - All reviews completed and approved!

@ramaghanta ramaghanta merged commit b545363 into main Jun 2, 2025
6 checks passed
@ramaghanta ramaghanta deleted the skip-check-published-for-templates-and-new-repos branch June 2, 2025 19:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

check published action should skip template repositories

3 participants