Skip to content

Conversation

Copy link
Contributor

Copilot AI commented Aug 8, 2025

Updates @checkdigit/prettier-config from version 6.1.0 to the latest 7.1.1 to maintain consistent code style with the latest formatting rules.

Changes Made

  • Updated dependency: Bumped @checkdigit/prettier-config from ^6.1.0 to ^7.1.1 in package.json
  • Applied formatting: Ran npm run prettier:fix to apply new formatting rules from the updated config
  • Fixed ESLint issues: Updated ESLint disable comments that were affected by the prettier formatting changes

Key Formatting Changes

The new prettier version introduced stricter formatting rules that affected:

  • Function call argument formatting (breaking long arguments across multiple lines)
  • Array literal formatting (breaking elements across lines for better readability)
  • Consistent spacing and line breaks

Verification

All code quality checks pass:

  • ✅ TypeScript compilation (npm run ci:compile)
  • ✅ ESLint linting (npm run ci:lint)
  • ✅ Prettier formatting (npm run ci:style)

The formatting changes are purely stylistic and do not affect functionality. ESLint disable comments for security rules (no-secrets/no-secrets, @checkdigit/no-card-numbers) and code quality rules (sonarjs/no-nested-assignment) were repositioned to match the new formatting.

Fixes #27.


✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

Copy link
Contributor Author

Copilot AI commented Aug 8, 2025

@lukebrdn 👋 This repository doesn't have Copilot instructions. With Copilot instructions, I can understand the repository better, work faster and produce higher quality PRs.

I can generate a .github/copilot-instructions.md file for you automatically. Click here to open a pre-filled issue and assign it to me. I'll write the instructions, and then tag you for review.

Copilot AI changed the title [WIP] update @checkdigit/prettier-config to latest version Update @checkdigit/prettier-config to 7.1.1 and apply formatting changes Aug 8, 2025
Copilot AI requested a review from lukebrdn August 8, 2025 19:40
@lukebrdn lukebrdn added the PATCH label Aug 11, 2025
Copy link
Contributor

@lukebrdn lukebrdn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please increment the package version. This change is a PATCH.

@lukebrdn lukebrdn requested a review from bobwieler August 11, 2025 15:57
@lukebrdn lukebrdn marked this pull request as ready for review August 11, 2025 15:57
Copilot AI review requested due to automatic review settings August 11, 2025 15:57
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the @checkdigit/prettier-config dependency from version 6.1.0 to 7.1.1 and applies the new formatting rules across the codebase. The changes are purely cosmetic and improve code readability through consistent formatting.

Key Changes:

  • Updated prettier configuration dependency to the latest version
  • Applied automated formatting to break long function calls and arrays across multiple lines
  • Repositioned ESLint disable comments to align with new formatting rules

Reviewed Changes

Copilot reviewed 5 out of 6 changed files in this pull request and generated no comments.

Show a summary per file
File Description
package.json Updates prettier config dependency and bumps package version
src/uuid-v5.ts Applies new formatting to function calls and array literals
src/uuid-v5.spec.ts Reformats test assertions for better readability
src/hash.ts Breaks function call arguments across multiple lines
src/hash.spec.ts Reformats test assertions with improved line breaks

Copilot AI and others added 4 commits August 11, 2025 12:04
Signed-off-by: Luke Bearden <luke.bearden@gmail.com>
Co-authored-by: lukebrdn <3859351+lukebrdn@users.noreply.github.com>
Signed-off-by: Luke Bearden <luke.bearden@gmail.com>
Copy link
Contributor

@carlansley carlansley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm @lukebrdn. your best work yet.

@github-actions
Copy link

❌ PR review status - has 1 reviewer outstanding

Copy link
Contributor

@bobwieler bobwieler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lftm!

@github-actions
Copy link

Beta Published - Install Command: npm install @checkdigit/hash@4.0.1-PR.28-74ce

@bobwieler bobwieler self-requested a review August 11, 2025 18:25
Copy link
Contributor

@bobwieler bobwieler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

slftm!

@lukebrdn lukebrdn merged commit 78af161 into main Aug 11, 2025
9 checks passed
@lukebrdn lukebrdn deleted the copilot/fix-27 branch August 11, 2025 20:24
lukebrdn added a commit that referenced this pull request Aug 12, 2025
…ges (#28)

Signed-off-by: Luke Bearden <luke.bearden@gmail.com>
Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: lukebrdn <3859351+lukebrdn@users.noreply.github.com>
Co-authored-by: Luke Bearden <luke.bearden@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

update @checkdigit/prettier-config to latest version

4 participants