-
Notifications
You must be signed in to change notification settings - Fork 0
Update @checkdigit/prettier-config to 7.1.1 and apply formatting changes #28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@lukebrdn 👋 This repository doesn't have Copilot instructions. With Copilot instructions, I can understand the repository better, work faster and produce higher quality PRs. I can generate a .github/copilot-instructions.md file for you automatically. Click here to open a pre-filled issue and assign it to me. I'll write the instructions, and then tag you for review. |
817e31b to
f185985
Compare
lukebrdn
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please increment the package version. This change is a PATCH.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR updates the @checkdigit/prettier-config dependency from version 6.1.0 to 7.1.1 and applies the new formatting rules across the codebase. The changes are purely cosmetic and improve code readability through consistent formatting.
Key Changes:
- Updated prettier configuration dependency to the latest version
- Applied automated formatting to break long function calls and arrays across multiple lines
- Repositioned ESLint disable comments to align with new formatting rules
Reviewed Changes
Copilot reviewed 5 out of 6 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| package.json | Updates prettier config dependency and bumps package version |
| src/uuid-v5.ts | Applies new formatting to function calls and array literals |
| src/uuid-v5.spec.ts | Reformats test assertions for better readability |
| src/hash.ts | Breaks function call arguments across multiple lines |
| src/hash.spec.ts | Reformats test assertions with improved line breaks |
Signed-off-by: Luke Bearden <luke.bearden@gmail.com>
Co-authored-by: lukebrdn <3859351+lukebrdn@users.noreply.github.com> Signed-off-by: Luke Bearden <luke.bearden@gmail.com>
6b2742b to
01c965d
Compare
carlansley
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm @lukebrdn. your best work yet.
|
❌ PR review status - has 1 reviewer outstanding |
bobwieler
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lftm!
|
Beta Published - Install Command: |
bobwieler
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
slftm!
…ges (#28) Signed-off-by: Luke Bearden <luke.bearden@gmail.com> Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: lukebrdn <3859351+lukebrdn@users.noreply.github.com> Co-authored-by: Luke Bearden <luke.bearden@gmail.com>
Updates
@checkdigit/prettier-configfrom version 6.1.0 to the latest 7.1.1 to maintain consistent code style with the latest formatting rules.Changes Made
@checkdigit/prettier-configfrom^6.1.0to^7.1.1in package.jsonnpm run prettier:fixto apply new formatting rules from the updated configKey Formatting Changes
The new prettier version introduced stricter formatting rules that affected:
Verification
All code quality checks pass:
npm run ci:compile)npm run ci:lint)npm run ci:style)The formatting changes are purely stylistic and do not affect functionality. ESLint disable comments for security rules (
no-secrets/no-secrets,@checkdigit/no-card-numbers) and code quality rules (sonarjs/no-nested-assignment) were repositioned to match the new formatting.Fixes #27.
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.