Update to prettier 3.6.1 #56
Conversation
|
Beta Published - Install Command: |
There was a problem hiding this comment.
Pull Request Overview
This PR updates the prettier configuration to version 3.6.1 and synchronizes various dependency and Node.js engine versions across configuration files and CI workflows.
- Bump package version and update prettier version checks
- Update peerDependencies and add a new prettier plugin
- Update Node.js versions in CI workflows and package engine
Reviewed Changes
Copilot reviewed 6 out of 7 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| package.json | Version bump, updated prettier version checks, and dependency updates including engine version change |
| index.json | Added a new prettier plugin entry |
| SECURITY.md | Updated version support details |
| .github/workflows/publish.yml | Updated Node.js version used in publish workflow |
| .github/workflows/publish-beta.yml | Updated Node.js version and removed a beta package validation step |
| .github/workflows/ci.yml | Updated Node.js versions in CI workflows |
Comments suppressed due to low confidence (2)
.github/workflows/publish-beta.yml:38
- The removal of the beta package validation step may reduce confidence in the beta release process. Confirm that this change is intentional and consider updating documentation to explain the revised validation strategy.
run: npm publish --tag beta
package.json:38
- [nitpick] Ensure that the Node.js engine version specified in package.json is consistent with the updated versions used in CI workflows (i.e., Node.js 24.x). This alignment may prevent confusion about supported runtime versions.
"node": ">=22.15"
| "ci:lint": "", | ||
| "ci:style": "npm run prettier", | ||
| "ci:test": "npm run ci:style && prettier --version | grep -q '3.5.3'", | ||
| "ci:test": "npm run ci:style && prettier --version | grep -q '3.6.1'", |
There was a problem hiding this comment.
[nitpick] Consider using a more robust version comparison method instead of a hard-coded grep check to verify the Prettier version. This can help avoid false negatives due to minor formatting or version string changes.
| run: npm publish --tag beta | ||
| env: | ||
| NODE_AUTH_TOKEN: ${{ secrets.NPM_TOKEN_PUBLISH }} | ||
| - name: Validate Published Beta NPM Package |
There was a problem hiding this comment.
had to remove this action, since it doesn't currently work with non-typescript modules
|
❌ PR review status - has 1 reviewer outstanding |
Fixes #55