Support for TypeScript 5.8 #71
Conversation
|
Requires typescript-eslint/typescript-eslint#10884 to be resolved before publishing. |
le-cong
left a comment
le-cong
left a comment
There was a problem hiding this comment.
lgtm other than a few very minor things.
somehow i'm seeing this in my vscode, everything works including testing, this may be sth we can ignore?
src/compile.spec.ts
Outdated
|
|
||
| const exportDefaultFunctionModule = { | ||
| [`index.ts`]: `export default function () { return 'hello world' }\n`, | ||
| [`export-default=function-module.ts`]: `export default function () { return 'hello world' }\n`, |
There was a problem hiding this comment.
is this meant to be export-default-function-module?
There was a problem hiding this comment.
regarding the VSCode thing, moduleResolution is set to bundler and there is no change to this vs the prior version. Not sure why this wasn't an error before. Regardless, I can't think of a reason not to just set noEmit to true, since we never generate code using tsc directly. Try this out, hopefully makes VSCode happy.
|
Beta Published - Install Command: |
|
✅ PR review status - All reviews completed and approved! |
Other than the obvious (updating to TypeScript 5.8), the following changes were made:
noUncheckedSideEffectImportsesbuildwhere there was a difference in behavior between macOS and Linuxjest, only usenode:testrunner