TypeScript 5.9.3 #84
TypeScript 5.9.3 #84
Conversation
There was a problem hiding this comment.
Pull Request Overview
Updates TypeScript version requirement to 5.9.3 and bumps package version to 9.3.2, addressing issue #83.
- Updated TypeScript peer dependency requirement from ">=5.9.2 <6" to ">=5.9.3 <6"
- Added async keyword to map callback function in getFiles function
- Updated various dev dependencies to newer versions
Reviewed Changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| package.json | Version bump and dependency updates including TypeScript requirement change |
| src/compile.ts | Added async keyword to map callback function |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
|
@ramaghanta @le-cong @adcreare I removed the |
package.json
Outdated
| "typescript": ">=5.9.3 <6" | ||
| }, | ||
| "engines": { | ||
| "node": ">=22.15" |
There was a problem hiding this comment.
not a change in this PR, but I wonder if the node version here should be 22.18, since that's what's being used in the Lambda
There was a problem hiding this comment.
oh I see AWS just updated to 22.18 today. I'll update the PR.
|
Beta Published - Install Command: |
|
❌ PR review status - has 2 reviewers outstanding |
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 3 out of 4 changed files in this pull request and generated no new comments.
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
There was a problem hiding this comment.
@carlansley I gave this a try on aws-nock - https://github.com/checkdigit/aws-nock/pull/548
prettier failed - native binding error - performed the following:
- deleted package-lock
- deleted node_modules
- flushed my npm cache
That said I'm not sure typescript is having the limitation helps the issue.
So LGTM
Fixes #83